Replaced MLKit with ZXing for QR code scanning #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -371,7 +370,8 @@ dependencies { | |||
| implementation "androidx.camera:camera-lifecycle:1.3.2" | |||
| implementation "androidx.camera:camera-view:1.3.2" | |||
|
|
|||
| implementation "com.google.mlkit:barcode-scanning:17.2.0" | |||
| // Note: ZXing 3.5.3 is the latest stable release as of 2024/08/21 | |||
| implementation "com.google.zxing:core:$zxingVersion" | |||
There was a problem hiding this comment.
You are re-introducing this import. It's already there on line 278. If you want to use this updated one, replace the one from line 278
… ZXing core + removed ZXing android-integration
ThomasSession
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
[ ] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using theFixes #1234syntaxDescription
Replaces MLKit with ZXing for all QR code scanning.